[Asterisk-code-review] asterisk: Audit locking of channel when manipulating flags. (asterisk[master])

Joshua Colp asteriskteam at digium.com
Tue May 16 07:52:05 CDT 2017


Hello George Joseph, Jenkins2,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5625

to look at the new patch set (#2).

Change subject: asterisk: Audit locking of channel when manipulating flags.
......................................................................

asterisk: Audit locking of channel when manipulating flags.

When manipulating flags on a channel the channel has to be
locked to guarantee that nothing else is also manipulating
the flags. This change introduces locking where necessary to
guarantee this. It also adds helper functions that manipulate
channel flags and lock to reduce repeated code.

ASTERISK-26789

Change-Id: I489280662dba0f4c50981bfc5b5a7073fef2db10
---
M apps/app_chanspy.c
M apps/app_dial.c
M apps/app_disa.c
M apps/app_dumpchan.c
M apps/app_externalivr.c
M include/asterisk/channel.h
M main/autoservice.c
M main/bridge.c
M main/bridge_after.c
M main/bridge_channel.c
M main/channel.c
M main/file.c
M main/manager.c
M main/pbx.c
M main/pbx_builtins.c
M res/res_agi.c
M res/res_musiconhold.c
17 files changed, 143 insertions(+), 77 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/25/5625/2
-- 
To view, visit https://gerrit.asterisk.org/5625
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I489280662dba0f4c50981bfc5b5a7073fef2db10
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2



More information about the asterisk-code-review mailing list