[Asterisk-code-review] asterisk: Audit locking of channel when manipulating flags. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5624 )

Change subject: asterisk: Audit locking of channel when manipulating flags.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5624/1/include/asterisk/channel.h
File include/asterisk/channel.h:

PS1, Line 4332: /*!
              :  * \since 13.17.0
              :  * \brief Set a flag on a channel
              :  *
              :  * \param chan The channel to set the flag on
              :  * \param flag The flag to set
              :  */
              : 
              : void ast_channel_set_flag(struct ast_channel *chan, unsigned int flag);
              : 
              : /*!
              :  * \since 13.17.0
              :  * \param Test a flag on a channel
              :  *
              :  * \param chan The channel to test the flag on
              :  * \param flag The flag to test
              :  *
              :  * \retval 0 flag not set
              :  * \retval 1 flag set
              :  */
              : unsigned int ast_channel_test_flag(struct ast_channel *chan, unsigned int flag);
              : 
              : /*!
              :  * \since 13.17.0
              :  * \param Clear a flag on a channel
              :  *
              :  * \param chan The channel to clear the flag from
              :  * \param flag The flag to clear
              :  */
              : void ast_channel_clear_flag(struct ast_channel *chan, unsigned int flag);
I think mentioning that these calls will lock the channel and that it's safe to call these if the calling thread has already locked the channel would be good.


-- 
To view, visit https://gerrit.asterisk.org/5624
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I489280662dba0f4c50981bfc5b5a7073fef2db10
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-HasComments: Yes