[Asterisk-code-review] tcptls: Improve error messages for TLS connections. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5614 )

Change subject: tcptls: Improve error messages for TLS connections.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5614/1/main/tcptls.c
File main/tcptls.c:

Line 87: AST_THREADSTORAGE(err2str_threadbuf);
Why use thread local storage instead of just passing in a buffer like you do with err and the built-in ssl calls?  Saves permanently allocating 128 bytes per thread.


-- 
To view, visit https://gerrit.asterisk.org/5614
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7ae40ce88c0dc4e185c4df1ceb3a6ccc198f075b
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-HasComments: Yes