[Asterisk-code-review] res pjsip session: Use DNID on outgoing call leg. (asterisk[master])

[Yasin CANER]

Yasin CANER has posted comments on this change. ( https://gerrit.asterisk.org/5545 )

Change subject: res_pjsip_session: Use DNID on outgoing call leg.
......................................................................


Patch Set 5:

(4 comments)

added ast_strlen_zero for checking null. tested with /without setting callerid(dnid). there isnt any problem. checked re-invite sessions and there isnt problem.

https://gerrit.asterisk.org/#/c/5545/1/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 1275: 	if (pjsip_inv_invite(session->inv_session, tdata) != PJ_SUCCESS) {
> What impact does this have on reinvites? Is the To header correct in that c
i will update my patch. there isnt this function here in my patch. if it is , it breaks re-invites


https://gerrit.asterisk.org/#/c/5545/3/res/res_pjsip_session.c
File res/res_pjsip_session.c:

Line 880: static void set_to_header(struct ast_sip_session *session)
> Formatting guidelines:
i checked all coding. and have look at guidelines. whic compiler are you using? i use vim on putty.


PS3, Line 892: 	if (ast_strlen_zero(ast_channel_dialed(session->channel)->number.str)) {
             : 		ast_channel_unlock(session->channel);
             : 		return;
             : 	}
             : 
             : 	dlg_pool
> Change to below and there is almost nothing left referencing the dialed var
i am not sure why lock is need i will add that parts. it is my first commit sorry for all troubles.


Line 1279: 	return 0;
> This likely also needs to be done in ast_sip_session_refresh() for the same
it doesnt need because pjsip lib can handle it. pjsip lib chan switch to header and from header. if it is setted, it is wrong value because of using DNID variable.
in conclusion , pjsip library (pj_pool) can handle


-- 
To view, visit https://gerrit.asterisk.org/5545
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I77261b6e6e7962f7371b91d78b8124af050cab61
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-HasComments: Yes