[Asterisk-code-review] res pjsip session : fixed wrong From Header number On Re-invite (asterisk[master])

Yasin CANER asteriskteam at digium.com
Tue May 9 06:04:36 CDT 2017


Yasin CANER has posted comments on this change. ( https://gerrit.asterisk.org/5535 )

Change subject: res_pjsip_session : fixed wrong From Header number On Re-invite
......................................................................


Patch Set 1:

> If the set_from_header call is just removed, connected line updates
 > are going to fail. More research is going to be needed to figure
 > out the exact cause and determine a solution that keeps connected
 > line updates working.

it doesnt update any connected line or effective line here. it creates "from header " from connected line or effective line. pjsip library that means dialog pool can already handle it with first Invite. i will test anonymouse situation without this paremeter and add my view.

-- 
To view, visit https://gerrit.asterisk.org/5535
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I55a9caa7dc90e6c4c219cb09b5c2ec08af84a302
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Yasin CANER <yasin.caner at netgsm.com.tr>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list