[Asterisk-code-review] SDP: Change media address to specify our address to use. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5594 )

Change subject: SDP: Change media_address to specify our address to use.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5594/1//COMMIT_MSG
Commit Message:

Line 9: When we optionally set the media_address we are forcing the media to go
This is incorrect and changing the meaning of this option. The option media_address is to change the address in the SDP. The fact it binds is a separate option, and changing this behavior means you also have to deprecate the option in PJSIP and change the media_address option there.

Why was this done?


-- 
To view, visit https://gerrit.asterisk.org/5594
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I160d9fac322a075bd2557b430632544178196189
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes