[Asterisk-code-review] build: Fix deb build issues with fakeroot (asterisk[13.15])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/5359 )

Change subject: build: Fix deb build issues with fakeroot
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

It appears 'make uninstall' does not clean /usr/lib64 when asterisk was configured with:
I ran the following sequence as root:
./configure --prefix=/usr --libdir=/usr/lib64
make && make install
./configure --prefix=/usr --libdir=/usr/lib
make && make install
# received the warning telling me to 'make uninstall'
make uninstall && make install
# uninstall did not remove Asterisk from /usr/lib64, so the warning repeated.

The uninstall targets from https://gerrit.asterisk.org/5093 need updating to deal with cleaning /usr/lib64/libasterisk* and /usr/lib64/asterisk/modules when --libdir=/usr/lib.

https://gerrit.asterisk.org/#/c/5359/2/Makefile
File Makefile:

PS2, Line 690: 			echo "  * Manually remove the libraries from" ;\
             : 			echo "   $(_oldlibdir)" ;\
I feel like this is asking for trouble, we shouldn't tell people to manually remove things from /usr/lib or /usr/lib64.

I know this text is from a previous review so feel free to ignore this comment, I just felt the need to say something.


-- 
To view, visit https://gerrit.asterisk.org/5359
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I51739d4a03e60bff38be719b8d2ead0007afdd51
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13.15
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes