[Asterisk-code-review] astobj2: Prevent potential deadlocks with ao2 global obj rel... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/5361 )

Change subject: astobj2: Prevent potential deadlocks with ao2_global_obj_release
......................................................................


Patch Set 2:

(1 comment)

Not giving a -1 since your code is functional, just an idea of how to simplify/de-duplicate.

https://gerrit.asterisk.org/#/c/5361/2/main/astobj2.c
File main/astobj2.c:

Line 664: 		return;
Alternative approach could be to replace this entire function body:

__ao2_global_obj_replace_unref(holder, NULL, tag, file, line, func, name);

Could even make __ao2_global_obj_release an ABI compatibility stub, have astobj2.h define a macro to directly call __ao2_global_obj_replace_unref.


-- 
To view, visit https://gerrit.asterisk.org/5361
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idf40ae136b5070dba22cb576ea8414fbc9939385
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes