[Asterisk-code-review] res xmpp: Fix ref counting issue (asterisk[13])

[Anonymous Coward]

Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/5287 )

Change subject: res_xmpp: Fix ref counting issue
......................................................................


res_xmpp: Fix ref counting issue

The only remaining reference to the endpoint is in the endpoints
container, and because it is unlinked in ast_endpoint_shutdown, we don't
have to explicitly cleanup the endpoint ourselves.

Change-Id: I912a2692e52d3e2ed445b32d8ae3f9004bc2f2e8
---
M res/res_xmpp.c
1 file changed, 0 insertions(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved



diff --git a/res/res_xmpp.c b/res/res_xmpp.c
index 11fbd2a..e422c14 100644
--- a/res/res_xmpp.c
+++ b/res/res_xmpp.c
@@ -561,7 +561,6 @@
 	ast_xmpp_client_disconnect(client);
 
 	ast_endpoint_shutdown(client->endpoint);
-	ao2_cleanup(client->endpoint);
 	client->endpoint = NULL;
 
 	if (client->filter) {

-- 
To view, visit https://gerrit.asterisk.org/5287
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I912a2692e52d3e2ed445b32d8ae3f9004bc2f2e8
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>