[Asterisk-code-review] Unused realtime MOH classes not purged on 'moh reload' (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5319 )

Change subject: Unused realtime MOH classes not purged on 'moh reload'
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5319/2/res/res_musiconhold.c
File res/res_musiconhold.c:

Line 1705: 	struct ast_flags config_flags = {0};
I don't think recreating .conf based classes each time is the right answer here. I think if the status is CONFIG_STATUS_FILEUNCHANGED and musiconhold is enabled for realtime (like the check for FILEMISSING or FILEINVALID) then an ao2_t_callback should be done that removes all the realtime classes and leaves the rest alone.


-- 
To view, visit https://gerrit.asterisk.org/5319
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I42c78ea76528473a656f204595956c9eedcf3246
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Daniel Journo <dan at keshercommunications.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes