[Asterisk-code-review] res xmpp: Fix ref counting issue (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/5287 )

Change subject: res_xmpp: Fix ref counting issue
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5287/1/res/res_xmpp.c
File res/res_xmpp.c:

Line 564
I think this should stay? When endpoint_internal_create returns it bumps the endpoint's ref by 1. What removes it?

Also won't removing this cause a leak in some of the off nominal paths in client alloc? For instance, say the endpoint is created, but the buddies container is not then endpoint would be leaked?


-- 
To view, visit https://gerrit.asterisk.org/5287
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I912a2692e52d3e2ed445b32d8ae3f9004bc2f2e8
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-HasComments: Yes