[Asterisk-code-review] channel: Remove old epoll support and fixed max number of fi... (asterisk[master])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/5283 )

Change subject: channel: Remove old epoll support and fixed max number of file descriptors.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5283/1/main/channel.c
File main/channel.c:

PS1, Line 6748: 	/* Copy the FD's other than the generator fd */
              : 	ast_channel_internal_fd_clear_all(original);
              : 	for (x = 0; x < ast_channel_fd_count(clonechan); x++) {
              : 		if (x != AST_GENERATOR_FD)
              : 			ast_channel_set_fd(original, x, ast_channel_fd(clonechan, x));
              : 	}
This appears to be changing logic with regards to the generator fd on the channel. The old algorithm left the original's generator fd alone. The new algorithm clears the generator fd on the original. Is this intended/correct?


https://gerrit.asterisk.org/#/c/5283/1/main/channel_internal_api.c
File main/channel_internal_api.c:

PS1, Line 1440: 	/* The vector will grow and populate with -1 initialized positions as
              : 	 * needed.
              : 	 */
This comment doesn't make sense here. The vector isn't growing, and nothing is getting populated.


-- 
To view, visit https://gerrit.asterisk.org/5283
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a754b506c009b83dfdeeb08c2d2815db30ef928
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes