[Asterisk-code-review] app queue: Member stuck as pending after forwarding previous... (asterisk[certified/13.13])

[Joshua Colp]

Joshua Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/5248 )

Change subject: app_queue: Member stuck as pending after forwarding previous call from queue
......................................................................


app_queue: Member stuck as pending after forwarding previous call from queue

Queue member will get stuck in pending_members if queue calls a device
that is different from the one observed for state changes.

This patch removes members from pending_members as a result of channel stasis
events such as blind or attended transfers and hangup.

ASTERISK-26862 #close

Change-Id: I8bf6df487b9bb35726c08049ff25cdad5e357727
---
M apps/app_queue.c
1 file changed, 7 insertions(+), 0 deletions(-)

Approvals:
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, approved
  Robert Mordec: Looks good to me, but someone else must approve



diff --git a/apps/app_queue.c b/apps/app_queue.c
index d3afec2..54ccc5e 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -5503,6 +5503,13 @@
 			member->membername, (long)member->lastcall);
 		ao2_unlock(q);
 	}
+	/* Member might never experience any direct status change (local
+	 * channel with forwarding in particular). If that's the case,
+	 * this is the last chance to remove it from pending or subsequent
+	 * calls will not occur.
+	 */
+	pending_members_remove(member);
+
 	ao2_lock(q);
 	q->callscompleted++;
 	if (callcompletedinsl) {

-- 
To view, visit https://gerrit.asterisk.org/5248
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8bf6df487b9bb35726c08049ff25cdad5e357727
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: certified/13.13
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Robert Mordec <r.mordec at slican.pl>