[Asterisk-code-review] res pjsip session: Enable RFC3578 overlap dialing support. (asterisk[13])

Matthew Fredrickson asteriskteam at digium.com
Tue Mar 21 09:41:47 CDT 2017


Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/5200 )

Change subject: res_pjsip_session: Enable RFC3578 overlap dialing support.
......................................................................


Patch Set 2: Code-Review-1

Hey Richard,

First off, thanks for the great contribution!  A couple of quick things to understand about the merge policy for Asterisk.  We allow new feature submissions in the master branch regardless - but to get this feature included in the 13 and 14 branches, there needs to be a testsuite test added for this functionality.

So you have two choices:
1. Remove the 13/14 cherry picks and just contribute this to master.
2. Write an Asterisk testsuite test for this feature, and get that also contributed.

The testsuite can be a bit difficult to get setup locally - but we can help if you're have trouble.  Feel free to come to the #asterisk-dev channel on irc.freenode.net for questions.

Best wishes,
Matt

-- 
To view, visit https://gerrit.asterisk.org/5200
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iea444da3ee7c7d4f1fde1d01d138a3d7b0fe40f6
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Richard Begg <asterisk at meric.id.au>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list