[Asterisk-code-review] pjsip: prevent memory corruption on creation of xml bodies (asterisk[13])

Sean Bright asteriskteam at digium.com
Tue Mar 21 08:38:21 CDT 2017


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5171 )

Change subject: pjsip: prevent memory corruption on creation of xml bodies
......................................................................


Patch Set 2: -Code-Review

> > (1 comment)
 > >
 > > Just a whitespace change
 > 
 > pjproject has different formatting guidelines than asterisk.  They
 > use spaces.


Not in this particular case. It's obvious in the diff that the leading whitespace of Joshua's addition is different from the subsequent lines.

-- 
To view, visit https://gerrit.asterisk.org/5171
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I884b6f4e8233a355d0be687ec78d41bc0e4d3fd2
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Elson <joshelson at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: No



More information about the asterisk-code-review mailing list