[Asterisk-code-review] audiohook.c: Lost RTP packets lead to out-of-sync MixMonitor. (asterisk[master])

Sean Bright asteriskteam at digium.com
Sun Mar 19 11:50:48 CDT 2017


Hello Kevin Harwell, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5209

to look at the new patch set (#3).

Change subject: audiohook.c: Lost RTP packets lead to out-of-sync MixMonitor.
......................................................................

audiohook.c: Lost RTP packets lead to out-of-sync MixMonitor.

This is a bug because in function "ast_audiohook_write_frame" it checks
the variable other_factory_samples, just when other_factory_samples > 0
we will flush the factories to make them sync. when there is not any
rtp incoming the variable "other_factory_samples" will be 0, althogh
the result of "our_factory_ms - other_factory_ms" may very large, this
will lead to the record file not sync.

ASTERISK-26875 #close
Reported-by: Aaron An
Tested-by: Aaron An

Change-Id: Ia4d890fb8fc1636a7188502bab35f555685aea22
---
M main/audiohook.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/09/5209/3
-- 
To view, visit https://gerrit.asterisk.org/5209
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia4d890fb8fc1636a7188502bab35f555685aea22
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Aaron An <anjb at ti-net.com.cn>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>



More information about the asterisk-code-review mailing list