[Asterisk-code-review] main/audiohook.c: Fix bug in audiohook lead to out of sync ... (asterisk[master])

Sean Bright asteriskteam at digium.com
Fri Mar 17 15:46:41 CDT 2017


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5209 )

Change subject: main/audiohook.c:  Fix bug in audiohook lead to out of sync MixMonitor.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5209/1//COMMIT_MSG
Commit Message:

PS1, Line 7: main/audiohook.c:  Fix bug in audiohook lead to out of sync MixMonitor.
           : 
           : MixMonitor out of sync due to the delayed rtp stream after SIP 183 with
           : SDP. In function ast_audiohook_write_frame, if other_factory_samples is
           : 0, we never flush the factories although the result of
           : "our_factory_ms - other_factory_ms" may very large.
This could use some cleaning up. As written it's not entirely clear what was wrong or what was fixed.


Line 16: Tested-by: AaronAn
Missing space


-- 
To view, visit https://gerrit.asterisk.org/5209
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4d890fb8fc1636a7188502bab35f555685aea22
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Aaron An <anjb at ti-net.com.cn>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list