[Asterisk-code-review] transport symmetric: Add testsuite test (testsuite[master])

Mark Michelson asteriskteam at digium.com
Wed Mar 15 17:04:15 CDT 2017


Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/5168 )

Change subject: transport_symmetric:  Add testsuite test
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5168/1/tests/channels/pjsip/transport/symmetric/invite/sipp/invite.xml
File tests/channels/pjsip/transport/symmetric/invite/sipp/invite.xml:

PS1, Line 6: 	<!-- ereg 'check_it' doesn't work in an out-of-call scenario file because
           : 		there's no call to mark as failed so we have to explicitly kill sipp if the
           : 		regex didn't match. -->
This isn't an out of call scenario file, so this comment doesn't make sense here.


-- 
To view, visit https://gerrit.asterisk.org/5168
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I41f52d09eb015659f935af9b2505ad2aa56d13de
Gerrit-PatchSet: 1
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list