[Asterisk-code-review] Add rtcp-mux support (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5138 )

Change subject: Add rtcp-mux support
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/5138/3/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

PS3, Line 4562: 	m = packet[1] & 0x80;
              : 	pt = packet[1] & 0x7F;
              : 	if (m && pt >= 64 && pt <= 95) {
> That's not simpler.
Yes it is simpler.  It eliminates two bitwise & operations and a logical && operation at run-time.

The bitwise | operation in the replacement is a compile time computation.


-- 
To view, visit https://gerrit.asterisk.org/5138
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If46a93ba1282418d2803e3fd7869374da8b77ab5
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes