[Asterisk-code-review] app queue: Member stuck as pending after forwarding previous... (asterisk[13])

[Robert Mordec]

Robert Mordec has uploaded a new change for review. ( https://gerrit.asterisk.org/5210 )

Change subject: app_queue: Member stuck as pending after forwarding previous call from queue
......................................................................

app_queue: Member stuck as pending after forwarding previous call from queue

Queue member will get stuck permanently in pending_members if queue calls
a device that is different from the one observed for state changes.

This patch removes connected member from pending_members
after it was marked as "in_call".

ASTERISK-26862 #close

Change-Id: I8bf6df487b9bb35726c08049ff25cdad5e357727
---
M apps/app_queue.c
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/5210/1

diff --git a/apps/app_queue.c b/apps/app_queue.c
index f7cee6a..ab09a96 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -6939,6 +6939,13 @@
 			ast_debug(4, "Marked member %s as in_call \n", member->membername);
 			ao2_unlock(qe->parent);
 		}
+		/* Connected member may not ever leave the not in use state (local channels with forwarding in particular)
+		 * If this occurs we explicitly remove them from the pending members
+		 * container so that subsequent call attempts occur.
+		 */
+		if (member->status == AST_DEVICE_NOT_INUSE) {
+			pending_members_remove(member);
+		}
 
 		ast_queue_log(queuename, ast_channel_uniqueid(qe->chan), member->membername, "CONNECT", "%ld|%s|%ld", (long) (time(NULL) - qe->start), ast_channel_uniqueid(peer),
 													(long)(orig - to > 0 ? (orig - to) / 1000 : 0));

-- 
To view, visit https://gerrit.asterisk.org/5210
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8bf6df487b9bb35726c08049ff25cdad5e357727
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Robert Mordec <r.mordec at slican.pl>