[Asterisk-code-review] res pjsip: Symmetric transports (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/5156 )

Change subject: res_pjsip:  Symmetric transports
......................................................................


Patch Set 3:

(4 comments)

https://gerrit.asterisk.org/#/c/5156/1/CHANGES
File CHANGES:

PS1, Line 36: res_pjsip
            : ------------------
> Extra clarity?  Try correcting the awkward sentence structure.  The 'this' 
> Extra clarity?  Try correcting the awkward sentence structure.  The
 > 'this' in the sentence has nothing to refer to.
 > 
 > The awkwardness needs to be fixed in the many places I pointed out
 > last time where you copied the description.

"this transport" refers to the transport you've set the option on but fine.


https://gerrit.asterisk.org/#/c/5156/3/res/res_pjsip.c
File res/res_pjsip.c:

Line 2773: 	const pj_str_t x_name = { AST_SIP_X_AST_TXP, AST_SIP_X_AST_TXP_LEN};
> static const pj_str_t x_name =...
> static const pj_str_t x_name =...
 > 
 > You don't need to init it but on load time.
 > 

I have no clue what you mean.


https://gerrit.asterisk.org/#/c/5156/3/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

Line 557: 				(AST_SIP_X_AST_TXP_LEN + strlen(transport_id) + 1));
> You aren't counting the ':' anymore.
Done


https://gerrit.asterisk.org/#/c/5156/3/res/res_pjsip/pjsip_message_ip_updater.c
File res/res_pjsip/pjsip_message_ip_updater.c:

Line 158: 	const pj_str_t x_name = {  AST_SIP_X_AST_TXP,  AST_SIP_X_AST_TXP_LEN};
> static const...
> static const...
> 

Again, don't have a clue.  Why would this need to be static?
 We don't make them static anywhere else.


-- 
To view, visit https://gerrit.asterisk.org/5156
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ee1f51473da32ca54b877cd158523efcef9655f
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes