[Asterisk-code-review] res/res pjsip refer: call xfer w/o extension (asterisk[13])

Joshua Colp asteriskteam at digium.com
Tue Mar 14 11:35:06 CDT 2017


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5182 )

Change subject: res/res_pjsip_refer: call xfer w/o extension
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5182/5/res/res_pjsip_refer.c
File res/res_pjsip_refer.c:

Line 827: 		pj_str_t s_exten = {"s", 1};
This doesn't actually need to be a pj_str_t. You can simply do an ast_copy_string(exten, "s", sizeof(exten)); to set it to 's'


-- 
To view, visit https://gerrit.asterisk.org/5182
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07403df66cf93f09e00a40ab5b41bfc6f72b1525
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list