[Asterisk-code-review] RFC sdp: Initial SDP creation (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5119 )

Change subject: RFC sdp: Initial SDP creation
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

Minor comments (so far).

https://gerrit.asterisk.org/#/c/5119/5/include/asterisk/sdp.h
File include/asterisk/sdp.h:

Line 547: struct ast_sdp *ast_sdp_create_from_state(const struct ast_sdp_state *sdp_state);
Still undocumented?


https://gerrit.asterisk.org/#/c/5119/5/include/asterisk/sdp_options.h
File include/asterisk/sdp_options.h:

PS5, Line 91: #define DECLARE_STRINGFIELD_GETTERS_SETTERS_FOR(field)	\
            : 	void ast_sdp_options_set_##field(struct ast_sdp_options *options, const char *field); \
            : 	void ast_sdp_options_build_va_##field(struct ast_sdp_options *options, const char *fmt, va_list ap) __attribute__((format(printf, 2, 0))); \
            : 	void ast_sdp_options_build_##field(struct ast_sdp_options *options, const char *fmt, ...) __attribute__((format(printf, 2, 3))); \
            : 	const char *ast_sdp_options_get_##field(struct ast_sdp_options *options)
            : 
            : #define DECLARE_GETTERS_SETTERS_FOR(type, field) \
            : 	void ast_sdp_options_set_##field(struct ast_sdp_options *options, type value); \
            : 	type ast_sdp_options_get_##field(struct ast_sdp_options *options)
I... don't like this because it is then not documented at all.


-- 
To view, visit https://gerrit.asterisk.org/5119
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbd877af7f5a4d3c74deead1bff8802661b0d48
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes