[Asterisk-code-review] res pjsip: Symmetric transports (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5156 )

Change subject: res_pjsip:  Symmetric transports
......................................................................


Patch Set 1:

(5 comments)

https://gerrit.asterisk.org/#/c/5156/1/CHANGES
File CHANGES:

PS1, Line 36:    If set to yes, when a request from a dynamic contact comes in on this
            :    transport, the transport name will be saved and used for subsequent
> > s/comes in on this transport/comes in/
Extra clarity?  Try correcting the awkward sentence structure.  The 'this' in the sentence has nothing to refer to.

The awkwardness needs to be fixed in the many places I pointed out last time where you copied the description.


https://gerrit.asterisk.org/#/c/5156/3/res/res_pjsip.c
File res/res_pjsip.c:

Line 2773: 	char *host = NULL;
static const pj_str_t x_name =...

You don't need to init it but on load time.

Also spacing around the {}.


https://gerrit.asterisk.org/#/c/5156/3/res/res_pjsip/config_transport.c
File res/res_pjsip/config_transport.c:

Line 557: 				(strlen("x-ast-txp:") + strlen(transport_id) + 1));
You aren't counting the ':' anymore.


https://gerrit.asterisk.org/#/c/5156/3/res/res_pjsip/pjsip_message_ip_updater.c
File res/res_pjsip/pjsip_message_ip_updater.c:

Line 158: 	pj_str_t name = { "x-ast-txp", 9};
static const...

Also spacing around the {}


Line 318: #define TRANSPORT_PREFIX_LENGTH 10
Is this not AST_SIP_X_AST_TXP_LEN + 1 for a colon?


-- 
To view, visit https://gerrit.asterisk.org/5156
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4ee1f51473da32ca54b877cd158523efcef9655f
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes