[Asterisk-code-review] tests/channels/pjsip/subscriptions/ast restart: Fix race con... (testsuite[master])

Richard Mudgett asteriskteam at digium.com
Tue Mar 14 10:20:55 CDT 2017


Hello Anonymous Coward #1000019, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5153

to look at the new patch set (#2).

Change subject: tests/channels/pjsip/subscriptions/ast_restart: Fix race condition.
......................................................................

tests/channels/pjsip/subscriptions/ast_restart: Fix race condition.

The test is failing on fast machines because they restart and fully boot
before the testsuite reconnects the AMI connection.  As a result the
expected second SUBSCRIPTION_ESTABLISHED event is never seen.

* Instead of ping-ponging back and forth between Asterisk and the SIPp
scenario, change the test to be more SIPp scenario driven.

* Enable PJSIP message debugging in the config file to ensure that logging
messages are enabled early enough to see the subscription recreation
NOTIFY message on fast machines.

Change-Id: Ie79c5ca9954287c1dda42a24305ccc8bdd0a6e07
---
M tests/channels/pjsip/subscriptions/ast_restart/configs/ast1/pjsip.conf
M tests/channels/pjsip/subscriptions/ast_restart/sipp/subscribe.xml
M tests/channels/pjsip/subscriptions/ast_restart/test-config.yaml
3 files changed, 35 insertions(+), 95 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/53/5153/2
-- 
To view, visit https://gerrit.asterisk.org/5153
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie79c5ca9954287c1dda42a24305ccc8bdd0a6e07
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>



More information about the asterisk-code-review mailing list