[Asterisk-code-review] RFC sdp: Initial SDP creation (asterisk[master])

George Joseph asteriskteam at digium.com
Mon Mar 13 14:57:18 CDT 2017


Hello Mark Michelson, Anonymous Coward #1000019, Joshua Colp,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5119

to look at the new patch set (#4).

Change subject: RFC sdp: Initial SDP creation
......................................................................

RFC sdp: Initial SDP creation

* Added additional fields to ast_sdp_options.
* Re-organized ast_sdp.
* Updated field names to correspond to RFC4566 terminology.
* Created allocs/frees for SDP children.
* Created getters/setters for SDP children where appropriate.
* Added ast_sdp_create_from_state.
* Refactored res_sdp_translator_pjmedia for changes.

Change-Id: Iefbd877af7f5a4d3c74deead1bff8802661b0d48
---
M include/asterisk/rtp_engine.h
A include/asterisk/sdp.h
M include/asterisk/sdp_options.h
D include/asterisk/sdp_priv.h
M include/asterisk/sdp_state.h
M include/asterisk/sdp_translator.h
M include/asterisk/stream.h
M main/rtp_engine.c
A main/sdp.c
M main/sdp_options.c
A main/sdp_private.h
D main/sdp_repr.c
M main/sdp_state.c
M main/sdp_translator.c
M main/stream.c
M res/res_sdp_translator_pjmedia.c
16 files changed, 1,875 insertions(+), 652 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/19/5119/4
-- 
To view, visit https://gerrit.asterisk.org/5119
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iefbd877af7f5a4d3c74deead1bff8802661b0d48
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>



More information about the asterisk-code-review mailing list