[Asterisk-code-review] chan pjsip: Don't assume a session will have a channel. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5165 )

Change subject: chan_pjsip: Don't assume a session will have a channel.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5165/1/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

Line 735: static int read_pjsip(void *data)
This function should always return 0.  Otherwise the ast_sip_push_task_synchronous() invoking it will give an invalid warning message about not being able to push this task when it actually did.

Instead you should do something like below in all cases:

func_args->ret = -1;
return 0;


-- 
To view, visit https://gerrit.asterisk.org/5165
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I113479cffff6ae64cf8ed089e9e1565223426f01
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes