[Asterisk-code-review] res musiconhold: moh general section is a class and issues w... (asterisk[master])

Anonymous Coward asteriskteam at digium.com
Thu Mar 9 18:32:03 CST 2017


Anonymous Coward #1000019 has submitted this change and it was merged. ( https://gerrit.asterisk.org/5144 )

Change subject: res_musiconhold: moh general section is a class and issues warning
......................................................................


res_musiconhold: moh general section is a class and issues warning

* res_musiconhold.c: Ensure the general section is not treated as
a moh class.

ASTERISK-26353 #close

Change-Id: Ia3dbd11ea2b43ab3e6c820a9827811dd24bea82d
---
M res/res_musiconhold.c
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, approved
  Richard Mudgett: Looks good to me, but someone else must approve
  Anonymous Coward #1000019: Verified
  Joshua Colp: Looks good to me, but someone else must approve



diff --git a/res/res_musiconhold.c b/res/res_musiconhold.c
index 70bb040..5ee1ac3 100644
--- a/res/res_musiconhold.c
+++ b/res/res_musiconhold.c
@@ -1748,6 +1748,7 @@
 					ast_log(LOG_WARNING, "Unknown option '%s' in [general] section of musiconhold.conf\n", var->name);
 				}
 			}
+			continue;
 		}
 
 		if (!(class = moh_class_malloc())) {

-- 
To view, visit https://gerrit.asterisk.org/5144
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3dbd11ea2b43ab3e6c820a9827811dd24bea82d
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Daniel Journo <dan at keshercommunications.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list