[Asterisk-code-review] app queue: Handle the caller being redirected out of a queue... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5149 )

Change subject: app_queue: Handle the caller being redirected out of a queue bridge
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/5149/1/apps/app_queue.c
File apps/app_queue.c:

Line 5928: 	if (ast_strlen_zero(queue_data->bridge_uniqueid)) {
> Yes, I noticed that the various handle_* functions were not consistently lo
And if all ao2_lock() is doing under the hook is calling pthread_mutex_lock, then we should be protecting reads and writes, no?


-- 
To view, visit https://gerrit.asterisk.org/5149
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba160907770de5a6c9efeffc9df5a13e9ea75334
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-HasComments: Yes