[Asterisk-code-review] media cache: Prefer ast file is readable() over access() (asterisk[master])

Sean Bright asteriskteam at digium.com
Wed Mar 8 17:26:42 CST 2017


Sean Bright has uploaded a new change for review. ( https://gerrit.asterisk.org/5148 )

Change subject: media_cache: Prefer ast_file_is_readable() over access()
......................................................................

media_cache: Prefer ast_file_is_readable() over access()

Change-Id: Icc0dc6e61b2e68d5cdcb74b016b2726a388c7def
---
M main/media_cache.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/48/5148/1

diff --git a/main/media_cache.c b/main/media_cache.c
index 2592f35..c58acdd 100644
--- a/main/media_cache.c
+++ b/main/media_cache.c
@@ -225,7 +225,7 @@
 	bucket_file = ao2_find(media_cache, uri, OBJ_SEARCH_KEY | OBJ_NOLOCK);
 	if (bucket_file) {
 		if (!ast_bucket_file_is_stale(bucket_file)
-			&& !access(bucket_file->path, R_OK)) {
+			&& ast_file_is_readable(bucket_file->path)) {
 			ast_copy_string(file_path, bucket_file->path, len);
 			if ((ext = strrchr(file_path, '.'))) {
 				*ext = '\0';

-- 
To view, visit https://gerrit.asterisk.org/5148
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc0dc6e61b2e68d5cdcb74b016b2726a388c7def
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>



More information about the asterisk-code-review mailing list