[Asterisk-code-review] res pjsip transport websocket: Add support for IPv6. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5134 )

Change subject: res_pjsip_transport_websocket: Add support for IPv6.
......................................................................


Patch Set 5: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5134/5/res/res_pjsip.c
File res/res_pjsip.c:

PS5, Line 2786: 	}
              : 
              : 	/* If the host is IPv6 turn the transport into an IPv6 version */
              : 	if (pj_strchr(&sip_uri->host, ':')) {
The type == UNSPECIFIED then return -1 is still needed.  Though it could be appended to the else-if ladder to avoid cases where we already know it could not be unspecified:

...
} else if (!slen) {
   type = UDP
} else if (type == UNSPECIFIED) {
   return -1
}


-- 
To view, visit https://gerrit.asterisk.org/5134
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1f9126f995b31dc38db8fdb58afd289b4ad1647
Gerrit-PatchSet: 5
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes