[Asterisk-code-review] RFC sdp: Initial SDP creation (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5119 )

Change subject: RFC sdp: Initial SDP creation
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.asterisk.org/#/c/5119/3/include/asterisk/stream.h
File include/asterisk/stream.h:

PS3, Line 206: /*!
             :  * \brief Get the opaque stream data
             :  *
             :  * \param stream The media stream
             :  *
             :  * \retval non-NULL success
             :  * \retval NULL failure
             :  *
             :  * \since 15
             :  */
             : void *ast_stream_get_data(struct ast_stream *stream);
             : 
             : /*!
             :  * \brief Set the opaque stream data
             :  *
             :  * \param stream The media stream
             :  * \param data Opaque data
             :  * \param data_free_fn Callback to free data when stream is freed. May be NULL for no action.
             :  *
             :  * \return data
             :  *
             :  * \since 15
             :  */
             : void *ast_stream_set_data(struct ast_stream *stream, void *data,
             : 	ast_stream_data_free_fn data_free_fn);
> Here's something to chew on. Do we think that there will ever be multiple p
It depends on the purpose of the data. If it's something you are frequently using in the media path, you want access to it fast. The faster the better, so direct access like this is good.


-- 
To view, visit https://gerrit.asterisk.org/5119
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbd877af7f5a4d3c74deead1bff8802661b0d48
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes