[Asterisk-code-review] res pjsip transport websocket: Add support for IPv6. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5134 )

Change subject: res_pjsip_transport_websocket: Add support for IPv6.
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/5134/4/res/res_pjsip.c
File res/res_pjsip.c:

Line 2758: 	pjsip_transport_type_e type = PJSIP_TRANSPORT_UNSPECIFIED;
Init value not used because it is always set below.


PS4, Line 2777: 	/* Determine the transport type to use */
              : 	if (!sip_uri->transport_param.slen) {
              : 		type = PJSIP_TRANSPORT_UDP;
              : 	} else {
              : 		type = pjsip_transport_get_type_from_name(&sip_uri->transport_param);
              : 	}
To honor sips probably should be:

type = pjsip_transport_get_type_from_name();
if (PJSIP_URI_SCHEME_IS_SIPS()) {
  if (type == UNSPECIFIED
     || !(pjsip_transport_get_flag_from_type(type) & PJSIP_TRANSPORT_SECURE)) {
    type = TLS;
  }
} else if (!slen) {
  type = UDP;
}

NOTE: The original if/else-if tests are also in pjproject since I think this is where we got it!


-- 
To view, visit https://gerrit.asterisk.org/5134
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1f9126f995b31dc38db8fdb58afd289b4ad1647
Gerrit-PatchSet: 4
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes