[Asterisk-code-review] pjsip/cli commands: pjsip show channelstats shows wrong codec (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5120 )

Change subject: pjsip/cli_commands: pjsip show channelstats shows wrong codec
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5120/6/channels/pjsip/cli_commands.c
File channels/pjsip/cli_commands.c:

Line 378: 			ast_format_cap_get_names(ast_channel_nativeformats(channel), &codec_buf),
I'm with George about using the native format capabilities string.  That string tends to be longer than the available column width.  The format shown should be either the rawreadformat or the rawwriteformat depending upon which you think is more important to show here.  The rawreadformat is what the peer is sending or has sent to us.  The rawwriteformat is what we are currently sending or have sent to the peer.  A NULL pointer needs to be tolerated.

ast_channel_rawreadformat(channel)
or
ast_channel_rawwriteformat(channel)


-- 
To view, visit https://gerrit.asterisk.org/5120
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3889ef6a8f6738fc312fab42db5efacd6e452b01
Gerrit-PatchSet: 6
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Daniel Journo <dan at keshercommunications.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Daniel Journo <dan at keshercommunications.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes