[Asterisk-code-review] res pjsip transport websocket: Add support for IPv6. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/5134 )

Change subject: res_pjsip_transport_websocket: Add support for IPv6.
......................................................................


Patch Set 2:

(3 comments)

res_pjsip.c:sip_dialog_create_from() around line 2791 likely needs to be fixed to create the IPv6 transport type value.

Also the selection code above (around line 2778) is in pjproject to determine the transport type.  If it sees that the URI scheme is sips it assumes the transport is TLS.  For websockets this assumption may not be valid.

https://gerrit.asterisk.org/#/c/5134/2/third-party/pjproject/patches/0014-Add-pjsip-transport-register-type-ipv6.patch
File third-party/pjproject/patches/0014-Add-pjsip-transport-register-type-ipv6.patch:

Line 8: preceed the IPv6 transport, but
but what?


Line 33: +        if (tp_flag & PJSIP_TRANSPORT_IPV6 &&
I'm a little surprised that there isn't a warning about mixing bitwise and logical operators without parentheses.


Line 46: +    if (tp_flag & PJSIP_TRANSPORT_IPV6 && parent) {
same here


-- 
To view, visit https://gerrit.asterisk.org/5134
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1f9126f995b31dc38db8fdb58afd289b4ad1647
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes