[Asterisk-code-review] Add rtcp-mux support (asterisk[14])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5139 )

Change subject: Add rtcp-mux support
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/5139/1//COMMIT_MSG
Commit Message:

PS1, Line 13: A new option, "rtcp_mux" has been added to endpoint configuration in
            : pjsip.conf. If set, then Asterisk will attempt to use rtcp-mux with
            : whatever it communicates with. Asterisk follows the rules set forth in
            : RFC 5761 with regards to falling back to standard RTCP behavior if the
            : far end does not indicate support for rtcp-mux.
This should be documented in CHANGES and UPGRADE.txt I'd say


https://gerrit.asterisk.org/#/c/5139/1/include/asterisk/res_pjsip.h
File include/asterisk/res_pjsip.h:

PS1, Line 679: 	/*! Use RTCP-MUX */
             : 	unsigned int rtcp_mux;
This needs ye ol' alembic


https://gerrit.asterisk.org/#/c/5139/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

Line 4571: 	unsigned char rtpdata[sizeof(rtp->rawdata)];
Why the change away from the usage of rtp->rawdata?


PS1, Line 5168: 			if (rtp->rtcp->type == AST_RTP_INSTANCE_RTCP_STANDARD) {
              : 				ast_sockaddr_set_port(&rtp->rtcp->them, ast_sockaddr_port(addr) + 1);
              : 
              : 				/* Update the local RTCP address with what is being used */
              : 				ast_sockaddr_set_port(&local, ast_sockaddr_port(&local) + 1);
              : 			}
Do we use this data anywhere and if so, should we set it even when muxed? (To the correct values)


-- 
To view, visit https://gerrit.asterisk.org/5139
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If46a93ba1282418d2803e3fd7869374da8b77ab5
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes