[Asterisk-code-review] RFC sdp: Initial SDP creation (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5119 )

Change subject: RFC sdp: Initial SDP creation
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/5119/3/include/asterisk/sdp_options.h
File include/asterisk/sdp_options.h:

Line 27:  * This is an enum because it is predicted that this eventually
this will


https://gerrit.asterisk.org/#/c/5119/3/include/asterisk/sdp_priv.h
File include/asterisk/sdp_priv.h:

Line 492:  * \returns Number of Attributes
Number of payloads


Line 547: struct ast_sdp *ast_sdp_create_from_state(struct ast_sdp_state *sdp_state);
This is undocumented.


https://gerrit.asterisk.org/#/c/5119/3/main/stream.c
File main/stream.c:

PS3, Line 215: 	stream->data = data;
             : 	stream->data_free_fn = data_free_fn;
It should be documented that stream data is NOT copied when copying a stream.


-- 
To view, visit https://gerrit.asterisk.org/5119
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbd877af7f5a4d3c74deead1bff8802661b0d48
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes