[Asterisk-code-review] pbx spool: Gracefully handle long lines in call files (asterisk[13])

Sean Bright asteriskteam at digium.com
Mon Mar 6 15:12:21 CST 2017


Hello Richard Mudgett, Anonymous Coward #1000019,

I'd like you to reexamine a change.  Please visit

    https://gerrit.asterisk.org/5125

to look at the new patch set (#2).

Change subject: pbx_spool: Gracefully handle long lines in call files
......................................................................

pbx_spool: Gracefully handle long lines in call files

Per the linked issue, we aren't checking the buffer filled by fgets()
to determine if it contains a newline, so we will fail to correctly
parse the trailing portion of a long line.

This patch increases the buffer size from 256 to 1024, and skips any
line that exceeds that length, logging a warning in the process.

ASTERISK-17067 #close
Reported by: Dave Olszewski

Change-Id: I51bcf270c1b4347ba05b43f18dc2094c76f5d7b0
---
M pbx/pbx_spool.c
1 file changed, 153 insertions(+), 122 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/25/5125/2
-- 
To view, visit https://gerrit.asterisk.org/5125
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I51bcf270c1b4347ba05b43f18dc2094c76f5d7b0
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>



More information about the asterisk-code-review mailing list