[Asterisk-code-review] chan pjsip: add a new function PJSIP DTMF MODE (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Fri Jun 30 09:46:57 CDT 2017


Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/5909 )

Change subject: chan_pjsip: add a new function PJSIP_DTMF_MODE
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.asterisk.org/#/c/5909/5/channels/pjsip/dialplan_functions.c
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/5909/5/channels/pjsip/dialplan_functions.c@1062
PS5, Line 1062: 
Shouldn't be 'chan' locked?


https://gerrit.asterisk.org/#/c/5909/5/channels/pjsip/dialplan_functions.c@1108
PS5, Line 1108: 
Shouldn't be 'chan' locked?



-- 
To view, visit https://gerrit.asterisk.org/5909
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I20eef5da3e5d1d3e58b304416bc79683f87e7612
Gerrit-Change-Number: 5909
Gerrit-PatchSet: 5
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 30 Jun 2017 14:46:57 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170630/f33bc55f/attachment.html>


More information about the asterisk-code-review mailing list