[Asterisk-code-review] chan pjsip: send indication for a video refresh for h264 (asterisk[14])

[Kevin Harwell]

Kevin Harwell has uploaded this change for review. ( https://gerrit.asterisk.org/5938


Change subject: chan_pjsip: send indication for a video refresh for h264
......................................................................

chan_pjsip: send indication for a video refresh for h264

When needed chan_pjsip was sending a video refresh request for vp8, but not
h264. When using h264 this would sometimes cause the video to be absent. A
request is now sent for h264 as well.

ASTERISK-27098 #close

Change-Id: If96c4fe319442bf58c68f0dbbd25dae2f7b509b9
---
M channels/chan_pjsip.c
1 file changed, 3 insertions(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/38/5938/1

diff --git a/channels/chan_pjsip.c b/channels/chan_pjsip.c
index f565ea8..50b61af 100644
--- a/channels/chan_pjsip.c
+++ b/channels/chan_pjsip.c
@@ -1410,10 +1410,12 @@
 			/* FIXME: Only use this for VP8. Additional work would have to be done to
 			 * fully support other video codecs */
 
-			if (ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), ast_format_vp8) != AST_FORMAT_CMP_NOT_EQUAL) {
+			if (ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), ast_format_vp8) != AST_FORMAT_CMP_NOT_EQUAL ||
+				ast_format_cap_iscompatible_format(ast_channel_nativeformats(ast), ast_format_h264) != AST_FORMAT_CMP_NOT_EQUAL) {
 				/* FIXME Fake RTP write, this will be sent as an RTCP packet. Ideally the
 				 * RTP engine would provide a way to externally write/schedule RTCP
 				 * packets */
+
 				struct ast_frame fr;
 				fr.frametype = AST_FRAME_CONTROL;
 				fr.subclass.integer = AST_CONTROL_VIDUPDATE;

-- 
To view, visit https://gerrit.asterisk.org/5938
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: newchange
Gerrit-Change-Id: If96c4fe319442bf58c68f0dbbd25dae2f7b509b9
Gerrit-Change-Number: 5938
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170629/1bb90d63/attachment.html>