[Asterisk-code-review] res rtp asterisk: Fix issues with ICE renegotiation. (asterisk[13])

Joshua Colp asteriskteam at digium.com
Wed Jun 28 09:14:07 CDT 2017


Joshua Colp has uploaded a new patch set (#2). ( https://gerrit.asterisk.org/5916 )

Change subject: res_rtp_asterisk: Fix issues with ICE renegotiation.
......................................................................

res_rtp_asterisk: Fix issues with ICE renegotiation.

When re-inviting to add more streams it is possible for
the role of existing ICE sessions to be changed to the
incorrect value. This results in subsequent refreshes
within the sessions getting a role conflict and the ICE
session breaking down. This change only sets the role to
be the new value if an ICE renegotiation is actually
going to happen, otherwise the existing role is preserved.

As well if we encounter a situation where a unidirectional
ICE negotiation happens and the other side does not send us
candidates we will not store any information for sending
traffic, even though we know where they are reachable. This
change fixes this by using the source of the ICE traffic
itself as the target if no candidates are known and we
receive some ICE traffic.

ASTERISK-27088

Change-Id: I71228181e358917fcefc3100fad21b2fc02a59a9
---
M res/res_rtp_asterisk.c
1 file changed, 18 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/16/5916/2
-- 
To view, visit https://gerrit.asterisk.org/5916
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I71228181e358917fcefc3100fad21b2fc02a59a9
Gerrit-Change-Number: 5916
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170628/872db534/attachment-0001.html>


More information about the asterisk-code-review mailing list