[Asterisk-code-review] res pjsip session.h: Remove unused callback in ast sip sessi... (asterisk[14])

Matthew Fredrickson asteriskteam at digium.com
Fri Jun 23 14:47:38 CDT 2017


Matthew Fredrickson has uploaded this change for review. ( https://gerrit.asterisk.org/5908


Change subject: res_pjsip_session.h: Remove unused callback in ast_sip_session_sdp_handler
......................................................................

res_pjsip_session.h: Remove unused callback in ast_sip_session_sdp_handler

It was realized that the handle_incoming_sdp_stream callback is unnecessary
and unused in ast_sip_session_sdp_handler.  This patch removes the callback
in question.

ASTERISK-27083 #close

Change-Id: Ifc0c68b4a5cba1ffd4df4f59f780847ffeeb99a9
---
M include/asterisk/res_pjsip_session.h
1 file changed, 0 insertions(+), 10 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/08/5908/1

diff --git a/include/asterisk/res_pjsip_session.h b/include/asterisk/res_pjsip_session.h
index e2a9066..e2a9857 100644
--- a/include/asterisk/res_pjsip_session.h
+++ b/include/asterisk/res_pjsip_session.h
@@ -327,16 +327,6 @@
 	 * \brief Create an SDP media stream and add it to the outgoing SDP offer or answer
 	 * \param session The session for which media is being added
 	 * \param session_media The media to be setup for this session
-	 * \param stream The stream on which to operate
-	 * \retval 0 The stream was not handled by this handler. If there are other registered handlers for this stream type, they will be called.
-	 * \retval <0 There was an error encountered. No further operation will take place and the current negotiation will be abandoned.
-	 * \retval >0 The stream was handled by this handler. No further handler of this stream type will be called.
-	 */
-	int (*handle_incoming_sdp_stream)(struct ast_sip_session *session, struct ast_sip_session_media *session_media, const struct pjmedia_sdp_session *sdp, struct pjmedia_sdp_media *stream);
-	/*!
-	 * \brief Create an SDP media stream and add it to the outgoing SDP offer or answer
-	 * \param session The session for which media is being added
-	 * \param session_media The media to be setup for this session
 	 * \param sdp The entire SDP as currently built
 	 * \retval 0 This handler has no stream to add. If there are other registered handlers for this stream type, they will be called.
 	 * \retval <0 There was an error encountered. No further operation will take place and the current SDP negotiation will be abandoned.

-- 
To view, visit https://gerrit.asterisk.org/5908
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc0c68b4a5cba1ffd4df4f59f780847ffeeb99a9
Gerrit-Change-Number: 5908
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Fredrickson <creslin at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170623/5963138a/attachment-0001.html>


More information about the asterisk-code-review mailing list