[Asterisk-code-review] bridge native rtp: Keep rtp instance refs on bridge channel (asterisk[13])

George Joseph asteriskteam at digium.com
Tue Jun 20 15:20:38 CDT 2017


Hello Richard Mudgett, Kevin Harwell, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/5854

to look at the new patch set (#4).

Change subject: bridge_native_rtp:  Keep rtp instance refs on bridge_channel
......................................................................

bridge_native_rtp:  Keep rtp instance refs on bridge_channel

There have been reports of deadlocks caused by an attempt to send
a frame to a channel's rtp instance after the channel has left the
native bridge and been destroyed.  This patch effectively causes the
bridge channel to keep a reference to the glue and both the audio
and video rtp instances until after the channel has detached
its framehooks and fully left the bridge.

ASTERISK-26978 #close
Reported-by: Ross Beer

Change-Id: I9e1ac49fa4af68d64826ccccd152593cf8cdb21a
---
M bridges/bridge_native_rtp.c
1 file changed, 409 insertions(+), 147 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/54/5854/4
-- 
To view, visit https://gerrit.asterisk.org/5854
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9e1ac49fa4af68d64826ccccd152593cf8cdb21a
Gerrit-Change-Number: 5854
Gerrit-PatchSet: 4
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170620/ada7bb0d/attachment.html>


More information about the asterisk-code-review mailing list