[Asterisk-code-review] SDP: Rework SDP offer/answer model and update capabilities m... (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5819 )

Change subject: SDP: Rework SDP offer/answer model and update capabilities merges.
......................................................................


Patch Set 4: Code-Review-1

(3 comments)

First base pass. Still digesting logic.

https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c
File main/sdp_state.c:

https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c@320
PS4, Line 320: 	max_streams = ast_sdp_options_get_max_streams(options);
Mark has done things with a per-type max streams limit. We should ensure we have a comment that this should be expanded to be that granularity as well.


https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c@536
PS4, Line 536: 	if (cb) {
Did you do this just so you can declare, neg_topology, etc if needed?


https://gerrit.asterisk.org/#/c/5819/4/main/sdp_state.c@817
PS4, Line 817: 	if (ast_sockaddr_isnull(address)) {
             : 		/* No address is set on the stream state. */
             : 		return -1;
             : 	}
Why this check before using the global connection address?



-- 
To view, visit https://gerrit.asterisk.org/5819
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If07fe6d79fbdce33968a9401d41d908385043a06
Gerrit-Change-Number: 5819
Gerrit-PatchSet: 4
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 16 Jun 2017 13:32:36 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170616/6c609eec/attachment-0001.html>