[Asterisk-code-review] res pjsip session: Correct inverted test in session outgoin... (asterisk[13])

George Joseph asteriskteam at digium.com
Wed Jun 14 08:34:12 CDT 2017


George Joseph has uploaded this change for review. ( https://gerrit.asterisk.org/5825


Change subject: res_pjsip_session:  Correct inverted test in session_outgoing_nat_hook
......................................................................

res_pjsip_session:  Correct inverted test in session_outgoing_nat_hook

There was a typo introduced in commit 776ffd77 which was preventing
the transport's external media address from being used.

ASTERISK-27024 #close
Reported-by: Christopher van de Sande
patches:
	patch.diff submitted by Florian Floimair (license 6892)

Change-Id: I7ec617171eaa2d86d2680b00cf37d5088adafc27
---
M res/res_pjsip_session.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/25/5825/1

diff --git a/res/res_pjsip_session.c b/res/res_pjsip_session.c
index 1fec089..c64d41f 100644
--- a/res/res_pjsip_session.c
+++ b/res/res_pjsip_session.c
@@ -3124,7 +3124,7 @@
 
 		if (!transport_state->localnet
 			|| (transport_state->localnet
-				&& ast_apply_ha(transport_state->localnet, &addr) == AST_SENSE_ALLOW)) {
+				&& ast_apply_ha(transport_state->localnet, &addr) != AST_SENSE_ALLOW)) {
 			ast_debug(5, "Setting external media address to %s\n", transport->external_media_address);
 			pj_strdup2(tdata->pool, &sdp->conn->addr, transport->external_media_address);
 		}

-- 
To view, visit https://gerrit.asterisk.org/5825
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ec617171eaa2d86d2680b00cf37d5088adafc27
Gerrit-Change-Number: 5825
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170614/29bda36b/attachment.html>


More information about the asterisk-code-review mailing list