[Asterisk-code-review] bridge: Add a deferred queue. (asterisk[14])

Joshua Colp asteriskteam at digium.com
Tue Jun 13 17:06:08 CDT 2017


Hello Mark Michelson, Jenkins2, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/5800

to look at the new patch set (#3).

Change subject: bridge: Add a deferred queue.
......................................................................

bridge: Add a deferred queue.

This change adds a deferred queue to bridging. If a bridge
technology determines that a frame can not be written and
should be deferred it can indicate back to bridging to do so.
Bridging will then requeue any deferred frames upon a new
channel joining the bridge.

This change has been leveraged for T.38 request negotiate
control frames. Without the deferred queue there is a race
condition between the bridge receiving the T.38 request
negotiate and the second channel joining and being in the
bridge. If the channel is not yet in the bridge then the T.38
negotiation fails.

A unit test has also been added that confirms that a T.38
request negotiate control frame is deferred when no other
channel is in the bridge and that it is requeued when a new
channel joins the bridge.

ASTERISK-26923

Change-Id: Ie05b08523f399eae579130f4a5f562a344d2e415
---
M bridges/bridge_native_rtp.c
M bridges/bridge_simple.c
M include/asterisk/bridge_channel.h
M include/asterisk/bridge_channel_internal.h
M include/asterisk/bridge_technology.h
M main/bridge.c
M main/bridge_channel.c
A tests/test_bridging.c
8 files changed, 397 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/00/5800/3
-- 
To view, visit https://gerrit.asterisk.org/5800
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 14
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie05b08523f399eae579130f4a5f562a344d2e415
Gerrit-Change-Number: 5800
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170613/9fa0f991/attachment.html>


More information about the asterisk-code-review mailing list