[Asterisk-code-review] chan pjsip: Multistream: Use underlying multistream structures. (asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/5760 )

Change subject: chan_pjsip: Multistream: Use underlying multistream structures.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5760/2/res/res_pjsip/pjsip_configuration.c
File res/res_pjsip/pjsip_configuration.c:

PS2, Line 380: 	/* XXX This topology creation may not work as-is for multistream.
             : 	 * The problem is that the conversion from format_cap to topology
             : 	 * will only create a stream per media type. If the topology should
             : 	 * have multiple audio/video streams, then a different method
             : 	 * will need to be used
             : 	 */
Per our discussion on the mailing list this is actually fine. It may also be worthwhile making this part of the core ACO/sorcery work for use by other things in the future.


-- 
To view, visit https://gerrit.asterisk.org/5760
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0358ea3108e2c06ae43308abddf216a23deccb90
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-HasComments: Yes