[Asterisk-code-review] res pjsip: Add support for returning only reachable contacts... (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change. ( https://gerrit.asterisk.org/5752 )

Change subject: res_pjsip: Add support for returning only reachable contacts and use it.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/5752/1/res/res_pjsip/location.c
File res/res_pjsip/location.c:

Line 239: 		ao2_callback(contacts, OBJ_MULTIPLE | OBJ_UNLINK, contact_remove_unreachable, NULL);
I believe you need OJB_NODATA here. Otherwise, this ao2_callback will return a container of the removed contacts, which will end up being leaked.


-- 
To view, visit https://gerrit.asterisk.org/5752
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8233b4faa21ba3db114f5a42e946e4b191446f6c
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes