[Asterisk-code-review] res rtp asterisk: Fix mapping of pjsip's ICE roles to ours (asterisk[master])

Matthew Fredrickson asteriskteam at digium.com
Wed Jul 26 09:50:11 CDT 2017


Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/6092 )

Change subject: res_rtp_asterisk: Fix mapping of pjsip's ICE roles to ours
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

Let's get rid of the ast_assert

https://gerrit.asterisk.org/#/c/6092/4/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/6092/4/res/res_rtp_asterisk.c@715
PS4, Line 715: 	ast_assert(0);
As per IRC discussion, it should probably go.  Serves no purpose.



-- 
To view, visit https://gerrit.asterisk.org/6092
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia578ede1a55b21014581793992a429441903278b
Gerrit-Change-Number: 6092
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 26 Jul 2017 14:50:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170726/74b94eb0/attachment.html>


More information about the asterisk-code-review mailing list