[Asterisk-code-review] res pjsip pidf eyebeam body supplement: Use open for busy/in... (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/5749 )

Change subject: res_pjsip_pidf_eyebeam_body_supplement: Use open for busy/inuse.
......................................................................


Patch Set 4:

I'm not in love with this change because I do not think it goes far enough.  AST_EXTENSION_BUSY is still considered 'closed.' Using 'on-the-phone' is more appropriate than 'busy' in many cases, etc.

I won't -1 it because there is an obvious bug fix (switching the text node to an element). Beyond that fix, I'm not convinced that the other changes are really beneficial because they are incomplete.


-- 
To view, visit https://gerrit.asterisk.org/5749
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1f4d1224d6c9b3fd8b01e6c708885e72f6a3a49
Gerrit-Change-Number: 5749
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Journo <dan at keshercommunications.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 18 Jul 2017 15:18:26 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20170718/2da5d907/attachment.html>